This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PPC] Fix 16796



On Nov 10, 2004, at 1:00 PM, Nathan Sidwell wrote:


This is a partial fix for 16796 where we emit a load into rA
and then copy rA to rB.  It is partial, because this patch fixes
SF and DF mode regs, but not the integer mode registers.

What is happening is that flow2 replaces conditional branches
to the exit block with conditional return instructions.  After this,
the only path to the exit block is merged, and the load and the
move are now in the same bb.  It is not entirely the fault of the
register allocator -- we shouldn't really be changing cfg so
significantly after register allocation.

Really this should be done not by peepholes at all but by some other thing like maybe a combiner after we duplication the block. This will help so much other code that we will not have to do any tricks likes this again.

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]