This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Getting glibfortran to build on newlib targets aka. missing stdint.h (PR 14325)


On Monday 08 November 2004 20:07, Hans-Peter Nilsson wrote:
> On Mon, 8 Nov 2004, Paolo Bonzini wrote:
> > > + # $1=typename, $2=alt1, $3=alt2, $4=cachevarsizename, $5=sizeof,
> > > $6=msgfrag. + AC_DEFUN([LIBGFOR_INTTYPE], [
> > > +  AC_CHECK_TYPES([$1],,
> > > +   [AC_CHECK_TYPES([$2],
> > > +           [ac_cv_gforlib_$1=$2],
> > > +    [AC_CHECK_SIZEOF([$3])
> > > +     if test "$$4" != $5; then
> >
> > Quite ugly...
>
> You're quite welcome, as long as we move forward.
>
> > I'd rather not have the fourth parameter and replace $$4 with
> > $ac_cv_sizeof_[]AS_TR_CPP([$3])
>
> Good suggestion.  I'd like to hear from someone with approval
> rights whether the whole idea of autoconfing this is ok with
> them.

I'm ok with the idea of come sort of autoconf check, although I'm not sure 
about the details of the implementation you suggest.

Hardcoding C typenames seem somewhat fragile, looping over [QHSDT]Imode types 
may be better. 

Also a prominent comment making it clear this is a kludge that can go away 
once GCC provides stdint.h.

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]