This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: target/18380: [3.4 regression]: _Unwind_FindTableEntry shouldn't be exported from libunwind.so.7


On Mon, Nov 08, 2004 at 01:04:09PM -0500, Jakub Jelinek wrote:
> On Mon, Nov 08, 2004 at 09:46:06AM -0800, H. J. Lu wrote:
> > 2004-11-08  H.J. Lu  <hongjiu.lu@intel.com>
> > 
> > 	PR target/18380
> > 	* config/ia64/unwind-ia64.h (_Unwind_FindTableEntry): Mark it
> > 	hidden.
> > 
> > 	* unwind-dw2.c (_Unwind_FindTableEntry): Removed.
> > 
> > --- gcc/config/ia64/unwind-ia64.h.unwind	2003-03-17 16:36:00.000000000 -0800
> > +++ gcc/config/ia64/unwind-ia64.h	2004-11-08 09:18:09.350497373 -0800
> > @@ -28,4 +28,5 @@ struct unw_table_entry
> >  
> >  extern struct unw_table_entry *
> >  _Unwind_FindTableEntry (void *pc, unsigned long *segment_base,
> > -			unsigned long *gp);
> > +			unsigned long *gp)
> > +			__attribute__ ((__visibility__ ("hidden")));
> 
> Here you IMHO need to conditionalize on
> #ifdef HAVE_GAS_HIDDEN.
> 

Symbol visibility was added on 2000-01-03. I am not sure if such an old
binutils will work for gcc on ia64. Besides, we don't test it in
crt*.asm. I can add it if it is really needed.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]