This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [pch] Fix largefile.c on sparc and sparc64


Jakub Jelinek <jakub@redhat.com> writes:

> On Sun, Nov 07, 2004 at 12:56:14PM -0500, James A. Morrison wrote:
> > 
> > Jakub Jelinek <jakub@redhat.com> writes:
> > 
> > > On Sun, Nov 07, 2004 at 12:33:26PM -0500, James A. Morrison wrote:
> > > > 
> > > >  This fixes the largefile.c test cases on sparc and sparc64.  It doesn't fix
> > > > all the failures on sparc64, but setting TRY_EMPTY_VM_SPACE to something
> > > > off in never, never land for sparc64 doesn't fix those failures either.
> > > 
> > > Still you should IMHO set TRY_EMPTY_VM_SPACE to some > 4GB address for
> > > defined(__sparc__) && defined(__LP64__)
> > > and only use 0x60000000 for sparc32.
> > > 
> > > 	Jakub
> > 
> >  Ok, would it be better to use __LP64__ or __arch64__ ? 
> 
> __arch64__ is sparc64 specific while __LP64__ is more generic.
> It doesn't matter much because we can't get rid of __arch64__
> nor __LP64__ any time soon.
> My personal preference would be __LP64__, but both options are fine.
> 
> 	Jakub
> 

 Ok, how about 
Index: host-linux.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/host-linux.c,v
retrieving revision 1.3
diff -u -p -r1.3 host-linux.c
--- host-linux.c        15 Oct 2004 17:22:02 -0000      1.3
+++ host-linux.c        7 Nov 2004 18:15:11 -0000
@@ -77,6 +77,10 @@
 # define TRY_EMPTY_VM_SPACE    0x8000000000
 #elif defined(__s390__)
 # define TRY_EMPTY_VM_SPACE    0x60000000
+#elif defined(__sparc__) && defined(__LP64__)
+# define TRY_EMPTY_VM_SPACE    0x8000000000
+#elif defined(__sparc__)
+# define TRY_EMPTY_VM_SPACE    0x60000000
 #else
 # define TRY_EMPTY_VM_SPACE    0
 #endif

 after another set of sparc{,64}-linux bootstrap and test runs?

-- 
Thanks,
Jim

http://www.student.cs.uwaterloo.ca/~ja2morri/
http://phython.blogspot.com
http://open.nit.ca/wiki/?page=jim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]