This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

exgettext patch; gcc.pot regenerated


I've regenerated gcc.pot.  I've used the appended patch to avoid local 
srcdir and objdir paths getting embedded in gcc.pot which may slightly 
reduce the unnecessary churn when this file is regenerated; OK to commit 
this patch?

gcc.pot can be used to find places where ` is still used as a left quote 
in diagnostics.  For example, there are some of the C++ ones I listed in 
<http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00875.html> left; instances 
in separate programs such as the gcc driver, collect2, gcov and protoize 
(which can readily be changed to ' as a neutral quote but don't use the 
diagnostic machinery to get proper quotes so easily); many target-specific 
files; and the Objective-C front end.  Volunteers converting any of these 
to use %q %< and %> where the diagnostic machinery supporting those is 
used, or ' as a neutral quote where it isn't, would be welcome.

I'm using gcc.pot to identify C front end diagnostics that aren't covered 
by the testsuite (as indicated by not appearing in gcc.log), about 350 of 
them though some are not readily testable.  I don't have any good notion 
of what diagnostics are or are not closely enough related to the parser 
(although not in the parser source file) to need testsuite coverage, so it 
seems best to ensure every front end diagnostic that reasonably can be is 
covered in the testsuite before considering lack of regressions sufficient 
evidence that a new parser is ready for mainline.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)

2004-11-06  Joseph S. Myers  <joseph@codesourcery.com>

	* exgettext: Remove local srcdir and objdir paths from gcc.pot.

--- exgettext.orig	2004-05-18 10:12:46.000000000 +0000
+++ exgettext	2004-11-06 01:18:56.000000000 +0000
@@ -167,4 +167,7 @@
 	  --add-comments `cat $kopt` --files-from=$posr \
 	  --copyright-holder="Free Software Foundation, Inc." \
 	  --msgid-bugs-address="http://gcc.gnu.org/bugs.html"; \
-	  --language=c -o po/$package.pot
+	  --language=c -o po/$package.pot.tmp
+# Remove local paths from .pot file.
+sed "s:$srcdir/::g;s:$pwd/::g;" <po/$package.pot.tmp >po/$package.pot
+rm po/$package.pot.tmp


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]