This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix -m64 on powerpc-darwin for pic code



On Nov 2, 2004, at 4:56 PM, Stan Shebs wrote:

Although the ideas of the patch seem generally sensible, I'm curious
how it is you're getting an ICE; I'm trying various combos of flags,
can't get my sources-updated-this-morning build to choke on this bit.

Also, if you're going to do this sort of churn, might as well take the
opportunity to move the macho patterns to darwin.md.

I confess! I'm a dirty software hoarder, I've had a patch for this in my tree for a week, forgot about it while working on ABI problems. So yeah, your fix seems as good as any; do the darwin.md moves and let's get it all into the mainline. Post the updated patch too please, so I can see what the testsuite on my bleeding-edge Tiger G5 thinks of it.

Here is the new patch which moves the darwin specific stuff to darwin.md.

OK? Bootstrapped and tested on powerpc-darwin.


* config/darwin.c (machopic_indirect_data_reference): Call gen_macho_high and gen_macho_low instead of checking the mode and calling gen_macho_high_di directly. * config/rs6000/rs6000.c (rs6000_emit_move): Likewise. * config/rs6000/rs6000.md: Move most of TARGET_MACHO expand/insns to darwin.md. (movdf_low, movsf_low, movsf_low_st, movsi_low, macho_correct_pic, load_macho_picbase, macho_low, macho_high): Removed. (builtin_setjmp_receiver): Call gen_macho_high and gen_macho_low instead of checking the mode and calling gen_macho_high_di directly. * config/rs6000/darwin.md (load_macho_picbase_di): Use the MD constant. (movdf_low_si, movsf_low_si, movsf_low_st_si, movsi_low_st): Moved from rs6000.md. (macho_high): New expander. (macho_high_si): Renamed version of macho_high from rs6000.md. (macho_low): New expander. (macho_low_si): Renamed version of macho_low from rs6000.md. (load_macho_picbase): New expander. (load_macho_picbase_si): Renamed version of load_macho_picbase from rs6000.md. (macho_correct_pic): New expander. (macho_correct_pic_si): Renamed version of macho_correct_pic from rs6000.md.


Attachment: temp1.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]