This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Java: [BC] Implement type assertion table


Bryce> Index: link.cc
[ ... ]
Bryce> +void
Bryce> +_Jv_Linker::verify_type_assertions (jclass klass)

Everything in _Jv_Linker should be independent of the execution engine
(there's one bogus exception).  That's why all the interpreter-related
code is in interpret.cc.  So it seems a little weird to put this code
here.

OTOH if we plan to support this field in Class independent of the
engine, then we might as well just inline the code into
_Jv_Linker::verify_class().

Bryce> +      if (assertion_code == 0)
Bryce> +        // End of the table.
Bryce> +        return;

Should probably use JV_ASSERT_END_OF_TABLE instead of "0" here.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]