This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix -m64 on powerpc-darwin for pic code


Andrew Pinski <pinskia@physics.uc.edu> writes:

> Even for the following simple code we ICE:
> int i = 0;
> void f(void)
> {
>  i = 0;
> }
>
> This patch fixes the problem plus adds some needed cleanup
> to the darwin code with respect with -m64 and makes it harder
> to make the mistake to generate only the 32bit code.
>
> Even though this is a semi big patch, I am either making a new
> expand which makes sure that we can just call the non _si/_di
> functions versions of the generation of the instructions or
> the removal of the code which just to call those functions.

The changes look vaguely sensible, but I am not approving the patch,
because you didn't explain it in adequate detail.  You need to tell us
what the ICE was, why it happened, and why this is the correct fix.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]