This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: zero extend pointer converstions to unsigned long long
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Mike Stump <mrs at apple dot com>
- Cc: Richard Henderson <rth at redhat dot com>, "Joseph S. Myers" <jsm at polyomino dot org dot uk>, "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 01 Nov 2004 20:19:14 -0800
- Subject: Re: zero extend pointer converstions to unsigned long long
- References: <20040923230947.GL3721@redhat.com><7C2E84B2-0E62-11D9-8790-003065BDF310@apple.com><20040924201900.GA14392@redhat.com><35734430-127D-11D9-9765-000393941EE6@apple.com><F5E4F089-1661-11D9-8C12-003065A77310@apple.com><A994679B-2C78-11D9-8536-000D9330C092@apple.com>
Mike Stump <mrs@apple.com> writes:
>> http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02998.html
The problem with this is you really do need to honor ptr_extend on
targets where it's defined; on those targets, both sign and zero
extension will trash the pointer. However, I could see an argument
that this construct is no more broken on those targets after this
patch, than it was before, and you have made it work for a class of
targets where it didn't.
You should be using fold_convert, and you forgot to validate the
changes to the manual (there's an unbalanced squiggle brace, which
will cause both makeinfo and texi2dvi to barf). Please fix those.
zw