This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove timevar_get ()



On Nov 1, 2004, at 7:28 PM, Zack Weinberg wrote:


At 02 Nov 2004 11:22:29 +1100,
Ben Elliston wrote:

2004-11-02 Ben Elliston <bje@au.ibm.com>


	* timevar.h (timevar_get): Remove.
	* timevar.c (timevar_get): Remove unused function.

OK.


This is unrelated to your current patch series, but currently the
first thing timevar_push/pop/start/stop do is check the global
variable timevar_enable, and if it's false, they return.  It would be
more efficient if this check happened in their callers.  To do that,
timevar_enable needs to be globally visible, and those four functions
need to be shadowed by macros which just do if (timevar_enable) call
real function;.

Would you be willing to make that change?

I had that change but you rejected it because I could not show it improved
that much.


-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]