This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bootstrap failure on ppc-darwin
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: Geoffrey Keating <geoffk at geoffk dot org>
- Cc: gcc-patches at gcc dot gnu dot org, Nathan Sidwell <nathan at codesourcery dot com>
- Date: Mon, 1 Nov 2004 17:24:47 -0500
- Subject: Re: [PATCH] Fix bootstrap failure on ppc-darwin
- References: <28AE3EDD-2A9F-11D9-9310-000A95D692F4@physics.uc.edu> <m2is8qxhdr.fsf@greed.local>
On Nov 1, 2004, at 12:33 AM, Geoffrey Keating wrote:
Andrew Pinski <pinskia@physics.uc.edu> writes:
We had a block copy which was not being SRA'd but I don't know if we
should
have. This patch fixes the problem by not having the block copy of
the
struct by passing a pointer into bmp_iter_end_p instead of the struct
it self. Yes we optimize this case already so it should not slow it
down at all (in fact the bootstrap might be sped up because we have
to less work by SRAing the block copy). Someone should look into if
we
really should be SRAing the block copy in this case.
OK? Bootstrapped and testing on powerpc-darwin.
This is OK, but can you make sure there's a bugzilla about the
underlying
problem?
I filed PR 18268 for the underlying problem with a reduced testcase.
Thanks,
Andrew Pinski