This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tree-phinodes.c: Make sure an edge exist before addinga PHI argument.


On Sat, 2004-10-30 at 09:09 -0400, Kazu Hirata wrote:
> Hi,
> 
> Attached is a patch to tell add_phi_arg to reject a request to add a
> PHI argument if its associated edge does not exist.
> 
> One case that's trapped by the new gcc_assert is thread_block in
> tree-ssa-threadupdate.c, but that's fixed by
> 
>   http://gcc.gnu.org/ml/gcc-patches/2004-10/msg02666.html
> 
> I briefly looked over uses of add_phi_args.  I didn't find any place
> where PHI arguments are added before an edge.  According to Steven
> Bosscher, thread_block should be the only place that does that as far
> as he knows.
> 
> Tested on i686-pc-linux-gnu on top of
> 
>   http://gcc.gnu.org/ml/gcc-patches/2004-10/msg02666.html
> 
> OK to apply?
> 
> Kazu Hirata
> 
> 2004-10-30  Kazu Hirata  <kazu@cs.umass.edu>
> 
> 	* tree-phinodes.c (add_phi_arg): Add an assertion that the
> 	edge already exists.
This is fine.  Please install this patch.

Thanks,
Jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]