This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Some cleanups, mostly loop.c related


On Monday 01 November 2004 21:45, Zack Weinberg wrote:
> At Mon, 1 Nov 2004 21:21:47 +0100,
>
> Steven Bosscher wrote:
> > Hi,
> >
> > This moves around some functions and prototypes and updates some
> > comments.  Consider this preparation for removing loop, as well
> > as just moving functions to more appropriate places.  There are
> > no functional changes.
>
> Abstractly, this is fine, but I would like to know why it is necessary
> to move prototypes from expr.h to rtl.h.  That bit seems gratuitous.

Because the 1st line of expr.h says,

/* Definitions for code generation pass of GNU compiler.

And neither get_condition() nor canonicalize_condition() is part of
the code generation pass.  They're RTL analysis functions.  Most of
the functions in rtlanal.c (all of them??) have their prototype in
rtl.h so it seemed like TRTD to move these prototypes there as well.

> (Also note you typoed expr.h as expr.c in the changelog.)

Whoops.

Gr.
Steven



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]