This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Fix libcpp configury/portability issue
Gerald Pfeifer <gerald@pfeifer.com> writes:
> On Sun, 31 Oct 2004, Zack Weinberg wrote:
>> Try again with the second #ifdef being HAVE_ICONV, *not* HAVE_ICONV_H.
>
> This leads to a build failure for GCJ:
There are no inclusions of libcpp/internal.h anywhere in gcc/java (nor
should there be - any use of that header outside of cpplib is a bug).
And my patch has exactly the same effect as yours, it's just more
readable. Thus I am inclined to think that this must be an unrelated
problem.
> Definitely. This is a complete and utter mess: two config.h files
> plus auto-host.h, all containing definitions of HAVE_ICONV and
> HAVE_ICONV_H (though not all have both and the latter even is not
> consistent) is a software engineering nightmare.
I think maybe we should do with iconv.h what we already do with
libintl - have the intl directory determine the answer, and everyone
else just defers to that.
zw