This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] Patch for PR 17590: Tagging intrinsics with standard version


On Sun, Oct 31, 2004 at 02:23:12AM +0100, Paul Brook wrote:
> On Saturday 09 October 2004 18:34, Janne Blomqvist wrote:
> >  PR fortran/17590
> A few minor formatting nits for future reference:

[snip]

Point taken. I'll try to better my ways.

Anyway, I reopened the bug since I noticed that you had made some
style changes which broke it. Copy-pasting my explanation from
bugzilla:

"""

I'm reopening this PR since a bug crept in, apparently Paul changed the code to
be C89 conformant while it depended on C99 VLA:s to function properly. If you
look at intrinsic.c:check_intrinsic_standard you see that originally it contained:

  int name_len;
  name_len = strlen(name);
  char msgstr[name_len + 53];

while the committed version has:

  int name_len;
  char msgstr[name_len + 53];

i.e. msgstr is allocated before the correct length is known. I'll try to fix it
asap with some __builtin_alloca magic..

"""

-- 
Janne Blomqvist


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]