This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix garbage in diagnostics


On Sun, 31 Oct 2004, Gabriel Dos Reis wrote:

> | That function is still wrong in many ways.  I'll file separate bugs for my 
> | points in comment#7 in bug 17852.
> 
> I disagree with the part (1) of that comment.  The C++ front-end
> should uniformly use the format specifiers.  It was wrong fro
> c_parse_error() to use %s to display the 

It's parts 2 and 3 for which I've filed separate bugs, as your patch 
addressed part 1 by changing c_parse_error so it does now make sense for 
those formats to be used.

> The translation was broken before my patch -- it was saying
> 
>    const char* string = _(msgid);
> 
> then went on string-catenating with other stuff.        
> 
> The patch leaves it to error() to get the translated messages.

Which it will not do because the sentences are not in the message catalog.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]