This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Fix libcpp configury/portability issue
On Sat, 30 Oct 2004, Zack Weinberg wrote:
2004-10-30 Gerald Pfeifer <gerald@pfeifer.com>
* internal.h (HAVE_ICONV): #undef, before redefining.
Uh, how did you get to that point with HAVE_ICONV defined in the first
place?
This happens if HAVE_ICONV is defined, but not HAVE_ICONV_H. For example,
this happens if intl/config.h is included instead of libcpp/config.h, and
indeed that seems to happen.
I do not have the environment of the original, broken build left, but
verified that this indeed can happen; consider the following from one
of my nightly builders:
.... -I./../intl -I/sw/test/gcc/cvs/gcc/../libcpp/include ....
My patch makes the code in question more stable, I believe, which seems
like a good thing?
Gerald