This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran] Patch for PR 17590: Tagging intrinsics with standard version


On Saturday 09 October 2004 18:34, Janne Blomqvist wrote:
>  PR fortran/17590
>
>  * gfortran.h: Change GFC_STD_* flags to more appropriate
>  ones. (struct gfc_intrinsic_isym): Add field for standard. (struct
>  gfc_option_t): Add field for warning about use of nonstandard
>  intrinsics.
>  * intrinsic.c (add_sym): Add parameter for standard version, check
>  this against current standard. (add_sym_0): Pass standard
>  parameter to add_sym. (add_sym_1): Likewise. (add_sym_0s):
>  Likewise. (add_sym_1s): Likewise. (add_sym_1m):
>  Likewise. (add_sym_2): Likewise. (add_sym_2s):
>  Likewise. (add_sym_3): Likewise. (add_sym_3ml):
>  Likewise. (add_sym_3red): Likewise. (add_sym_3s):
>  Likewise. (add_sym_4): Likewise. (add_sym_4s):
>  Likewise. (add_sym_5): Likewise. (add_sym_5s):
>  Likewise. (make_generic): Add parameter for standard, check this
>  against currently selected standard. (add_functions): Add
>  parameter to tell which standard an intrinsic belongs
>  to. (add_subroutines): Likewise. (check_intrinsic_standard): New
>  function. (gfc_intrinsic_func_interface): Add call to
>  check_intrinsic_standard. (gfc_intrinsic_sub_interface): Likewise.
>  * lang.opt: Add Wnonstd-intrinsics option.
>  * options.c (gfc_init_options): Change to use new GFC_STD_* flags,
>  init new warning. (set_Wall): Add warning about nonstd
>  intrinsics. (gfc_handle_option): Change to use new GFC_STD_*
>  flags, handle new warning.
>  * invoke.texi: Update manual to include -Wnonstd-intrinsics.

Applied, thanks.

A few minor formatting nits for future reference:

+   has chosen. */

Need two spaces after the end of a sentence.

+check_intrinsic_standard(const char *name, int standard)

Need a space in between function name and parentheses

+  if ( ! gfc_option.warn_nonstd_intrinsics)

Should not be any space around "!"

+  strncpy(msgstr, name, name_len+1);

Need space either side of "+"

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]