This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bootstrap failure on ppc-darwin
- From: Nathan Sidwell <nathan at codesourcery dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 30 Oct 2004 20:27:30 +0100
- Subject: Re: [PATCH] Fix bootstrap failure on ppc-darwin
- Organization: CodeSourcery LLC
- References: <28AE3EDD-2A9F-11D9-9310-000A95D692F4@physics.uc.edu>
Andrew Pinski wrote:
We had a block copy which was not being SRA'd but I don't know if we should
have. This patch fixes the problem by not having the block copy of the
struct by passing a pointer into bmp_iter_end_p instead of the struct
it self. Yes we optimize this case already so it should not slow it
down at all (in fact the bootstrap might be sped up because we have
to less work by SRAing the block copy). Someone should look into if we
really should be SRAing the block copy in this case.
I am working on improving these iterators, and initial results are promising.
Andrew's patch is certainly fine as a workaround to get bootstrap working
and I recommend it as an obvious fix. Thanks Andrew!
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk