This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [3.4 PATCH] Fix -fwritable-strings (PR middle-end/18129)
- From: Roger Sayle <roger at eyesopen dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>
- Date: Sat, 30 Oct 2004 11:44:18 -0600 (MDT)
- Subject: Re: [3.4 PATCH] Fix -fwritable-strings (PR middle-end/18129)
On Sun, 24 Oct 2004, Jakub Jelinek wrote:
> 2004-10-24 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/18129
> * varasm.c (copy_constant): Don't copy STRING_CSTs if
> flag_writable_strings.
> (build_constant_desc): Call copy_constant unconditionally.
>
> * gcc.dg/20041024-1.c: New test.
Could you report which target triples you've bootstrapped and regression
tested this patch on? At this stage all changes to 3.4 need to go
through Mark, and his decision is made much easier if you can show that
you've followed protocol to check that this change is safe.
Thanks in advance,
Roger
--