This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [committed] fixincludes: less va_list rewriting


Mike Stump <mrs@apple.com> writes:

> We can avoid rewriting va_list, if the file included <stdarg.h> or if
> there is some other form of protection.
> 
> Tested on darwin.

Who approved this patch?

You'll note that in the Radar for this, what I proposed was:

> So my suggestion would be that if this fix is bothering you, split it
> into two parts, one part for standard files, another part for files
> that might be expecting the definition from stdio.h, and give the
> second part a bypass that includes 'stdarg.h'.

which is not what you did, and in fact your change is wrong because of
it.  Please back your change out.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]