This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] Windows patches.


>>>>> "Aaron" == Aaron W LaFramboise <aaronavay62@aaronwl.com> writes:

Aaron> 2004-10-25  Aaron W. LaFramboise  <aaronavay62@aaronwl.com>
Aaron> 	* testsuite/lib/libjava.exp (libjava_arguments): Fix CLASSPATH
Aaron> 	separator handling for Windows.

This is basically ok, but could you make one little change?

Aaron>       # Set the CLASSPATH environment variable
Aaron> !     verbose "CLASSPATH is .$sep$srcdir/$subdir$sep$objdir$sep$libgcj_jar"
Aaron>       global env
Aaron> !     set env(CLASSPATH) ".$sep$srcdir/$subdir$sep$objdir$sep$libgcj_jar"
I suggest using join.  Like:

    set env(CLASSPATH) [join [list . $srscdir/$subdir $objdir $libgcj_jar] \
                             $sep]
    verbose "CLASSPATH is $env(CLASSPATH)"

This is easier to read IMO.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]