This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New C parser [patch]


On Mon, 25 Oct 2004, Zack Weinberg wrote:

> > But I will say that we have C++ diagnostic regressions because of
> > "%<%>ifying".  The reason why we have this problem is because
> > c_parser_error takes a string but only does %s on it rather than passing
> > it on to the diagnostic mechanism.
> 
> c_parse(r)_error have serious i18n issues already: I don't think this
> one more makes much difference.  The way forward is to remove
> c_parse_error entirely...

The regressions in English messages in the C++ front end are separate from 
the i18n problems.  For now, my parser uses literal '' to get properly 
formatted English messages.  When this area is cleaned up, or if 
c_parse_error starts accepting %<%>, then it can start using %<%>.  For 
now, the i18n is no worse than with the existing parser, and a key design 
feature of this patch is that it tries to be as minimal as possible for a 
parser replacement: it will follow cleanups made to the existing code 
before it goes in, and it will facilitate further cleanups once it is in, 
but will avoid leading on cleanups or changes that don't need entangling 
with a new parser.  I will however put ??? comments anywhere (as here) 
where it is suggested that the status quo is a mess and a good subject for 
a future cleanup.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]