This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR16585: Fix setting/resetting of current_function_has_computed_jump
- From: Steven Bosscher <stevenb at suse dot de>
- To: Richard Henderson <rth at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 26 Oct 2004 00:18:29 +0200
- Subject: Re: PR16585: Fix setting/resetting of current_function_has_computed_jump
- Organization: SUSE Labs
- References: <200407050040.29130.stevenb@suse.de> <20041025221347.GC9403@redhat.com>
On Tuesday 26 October 2004 00:13, Richard Henderson wrote:
> On Mon, Oct 25, 2004 at 11:36:23PM +0200, Steven Bosscher wrote:
> > Does this approach look sane, or should I perhaps move this code
> > to cfgcleanup.c?
>
> This doesn't look like the best fix. I think that at minimum,
> the _clearing_ of current_function_has_computed_jump should be
> moved somewhere else. It might be best to still set it here,
> but I'm not sure.
Yeah, I thought it was an odd place to have this, too. In fact
I was thinking perhaps we should just not know about this
current_function_has_computed_jump thing until much later in
the compilation. The only pass that actually cares about this
is sched-rgn.
Gr.
Steven