This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING] Windows patches.


DJ Delorie wrote:
>>The first patch disables building fixincludes for targets where it
>>is not needed.  This was done previously, but got lost in the
>>fixincludes transition to toplevel.  It needs a configury
>>maintainer.
> 
> Target-specific changes in configury are normally approved by the
> target maintainers, not the configury maintainers, as only the target
> maintainers know if the change is correct.

(The patch was <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg00934.html>.)

This patch affects:
  alpha*-*-*vms*
  arm-semi-aof
  hppa1.1-*-osf*
  hppa1.1-*-bsd*, i370-*-opened*
  i[[3456789]]86-*-mingw32*
  *-*-cygwin*
  i[[3456789]]86-moss-msdos
  i[[3456789]]86-*-moss*
  i[[3456789]]86-*-pe
  powerpc-*-eabi
  powerpcle-*-eabi*
  powerpc-*-rtems*

QNX and AVR targets have indicated also that they don't want fixincludes.

For these targets, this patch restores the behavior of fixincludes
builds before it was moved to toplevel.

Does the patch really need to be signed off by all of these maintainers?
 Unless since fixincludes moved to toplevel one of these targets added
fixincludes rules, which is unlikely, there will be no change in
functionality , except for shorter build times, and perhaps the
difference between a currently broken build and a working build.

Aaron W. LaFramboise


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]