This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix LD_LIBRARY_PATH setting in testsuite


Eric Botcazou wrote:
Hello Mark,

H.J.'s patch to fix PR bootstrap/17684:

http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02881.html

had an unexpected side-effect: breaking the testsuite for the multilibed compiler on sparc-sun-solaris2.x (x>=7).

The problem is that LD_LIBRARY_PATH is not correctly set anymore: it doesn't contain the $(lib)/$(multilib_dir) pattern anymore. This originates in the following construct:

if { [is_remote host] == 0 && [which $compiler] != 0 } {
    foreach i "[exec $compiler --print-multi-lib]" {
	set mldir ""
	regexp -- "\[a-z0-9=/\.-\]*;" $i mldir
	set mldir [string trimright $mldir "\;@"]
	if { "$mldir" == "." } {
	    continue
	}
	if { [llength [glob -nocomplain ${rootme}/${mldir}/libgcc_s*.so.*]] == 1 } {
	    append libgcc_s_path ":${rootme}/${mldir}"
	}
    }
}

that is replicated in many testsuite driver files.

This patch is OK.


It would be swell if this code could be centralized in one place, but that can be a separate pathc.

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]