This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] arc backend patch


Ramana Radhakrishnan wrote:

> I just discovered a problem with the patch you applied / I sent in
> lib1funcs.asm . Its just that there is a gap between L and the actual
> label name.

Eww, I missed that too. This is what I committed as obvious to mainline/3.4 to
fix it.

> Further I seem to have made
> a mistake with the cmp being there. It should have been a sub.f as
> below in the code.

This is a separate issue and should be sent as a separate patch for approval.

> This also would need to be applied into 3.4/3.3
> Ok to commit ?

You forgot to specify how you tested this. Did you also test the previous
patch? How did it survive with such a typo?

Giovanni Bajo

Attachment: arc-typo.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]