This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH: 14035


>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:

Andreas> The casts to int should probably be changed to casts to
Andreas> uaddr.  I'm testing this patch now:

This is ok, just one minor nit.

Andreas> +	  _Jv_Utf8Const *name = klass->constants.data[(uaddr)superclass].utf8;

Space after the cast please.

Andreas> +	superclass = klass->constants.data[(uaddr)superclass].clazz;

Likewise.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]