This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] arc backend patches. Mainline.


Ramana Radhakrishnan wrote:

much better but still:

>> ChangeLog:
>>
>> 2004-10-18: Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
>> * config/arc/lib1funcs.asm(___umulsidi3):  Correct usage of flags

After the date, there should be exactly two spaces and nothing else before the
name.
After the name, there should be exactly two spaces and nothng esle before the
email.
There should be a blank link between the header line and the contents.
There should be exactly one space between the file name and the parenthesized
function name.
There should be exactly one space after the colon, before the change
description.

Really, this cannot be that hard. You have to copy the *exact* format of the
other ChangeLogs.


>> ChangeLog:
>> 2004-10-18:Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
>>
>>
>> * arc.h (REGNO_OK_FOR_BASE_P,REGNO_OK_FOR_INDEX_P,
>>   REG_OK_FOR_BASE, REG_OK_FOR_INDEX)  Fix for
>>   PR17317 .  Consider blink(r31) as a valid base and index register
>>   for loads.

This one has similar problems too. Two blank lines between the header line and
the content. The PR number usually go on its own line (see other ChangeLogs in
other directories). No colon after the parenthesis, etc.

>> ChangeLog:
>>
>> 2004-10-18:Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
>>
>> * config/arc/t-arc

This one is missing/incomplete.


BTW, I'll commit the patches for you if they get approved, so I'll fix up
remaining problems in ChangeLogs if any.

Giovanni Bajo



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]