This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] expr.c: Remove an obsolete comment.


Attached is a patch to remove an obsolete comment.

This comment does not seem to describe any code.  I looked at
expand_assignment, which handles MODIFY_EXPR, but I didn't find any
code that would be described by this comment.

OK to apply?

Kazu Hirata

2004-10-17  Kazu Hirata  <>

	* expr.c (expand_expr_real_1): Remove an obsolete comment.

Index: expr.c
RCS file: /cvs/gcc/gcc/gcc/expr.c,v
retrieving revision 1.726
diff -u -r1.726 expr.c
--- expr.c	3 Oct 2004 22:50:18 -0000	1.726
+++ expr.c	17 Oct 2004 15:55:49 -0000
@@ -8064,14 +8064,6 @@
     case MODIFY_EXPR:
-	/* If lhs is complex, expand calls in rhs before computing it.
-	   That's so we don't compute a pointer and save it over a
-	   call.  If lhs is simple, compute it first so we can give it
-	   as a target if the rhs is just a call.  This avoids an
-	   extra temp and copy and that prevents a partial-subsumption
-	   which makes bad code.  Actually we could treat
-	   component_ref's of vars like vars.  */
 	tree lhs = TREE_OPERAND (exp, 0);
 	tree rhs = TREE_OPERAND (exp, 1);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]