This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, rfc] add case-values-threshold as a param
- From: Roger Sayle <roger at eyesopen dot com>
- To: Eric Christopher <echristo at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 13 Oct 2004 18:33:41 -0600 (MDT)
- Subject: Re: [patch, rfc] add case-values-threshold as a param
On Wed, 13 Oct 2004, Eric Christopher wrote:
> 2004-10-12 Eric Christopher <echristo@redhat.com>
>
> * params.def: Add PARAMS_CASE_VALUES_THRESHOLD.
> * expr.c (case_value_threshold): Rewrite and use. Include
> params.h.
> * doc/invoke.texi: Document new param.
You'll also need to update Makefile.in, to add $(PARAMS_H) to expr.o's
dependencies, now that params.h is #included in expr.c.
With that change, this patch is OK for gcc 4.1. It's technically neither
a clean-up nor a bug fix, so officially it's not really suitable for
mainline during stage3. I was considering being lenient, but according
to gcc/ChangeLog you haven't committed a patch that's resolved a bugzilla
PR since c/16046 on 2004-09-10 :< Even though I agree this patch is
totally safe, the fact that the number of open bugs targetted for 4.0.0
goes up with each of Mark's branch status reports, means that a strict
line needs to be drawn somewhere.
Hopefully, you won't consider this unfair.
Roger
--