This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Disabling top level fixincludes
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: zack at codesourcery dot com
- Cc: bkorb at veritas dot com, gcc-patches at gcc dot gnu dot org
- Date: Wed, 13 Oct 2004 14:35:14 -0400 (EDT)
- Subject: Re: Disabling top level fixincludes
- References: <416C4366.DA4A6C3E@veritas.com> <873c0j35i7.fsf@codesourcery.com>
> Even better, leave the dup2 in the code alone, and - only if someone
> complains - put
>
> #if !defined HAVE_DUP2 && defined HAVE_FCNTL_DUPFD
> #define dup2(ofd, nfd) fcntl(ofd, F_DUPFD, nfd)
> #endif
>
> in an appropriate header, plus appropriate configure goo.
Even better, put all the "goo" in a libiberty dup2 replacement.
There's also a dup2 replacement in collect2.c that uses a different
backup mechanism than fcntl, this could also be merged and zapped.
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu