This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Vectorizer: bug fix for component ref support


On Wed, Oct 13, 2004 at 02:46:14PM +0200, Ira Rosen wrote:
> !                   dr = analyze_array (stmt, TREE_OPERAND (symbl, 0), DR_IS_READ(dr));
> !                   if (TREE_CODE (DR_BASE_NAME (dr)) == COMPONENT_REF) 
> ! 		    STMT_VINFO_MEMTAG (stmt_info) = 
> ! 		      vect_get_base_and_bit_offset (dr, DR_BASE_NAME (dr), NULL_TREE, 
> ! 						    loop_vinfo, &offset, &base_aligned_p);

Any reason not to call vect_get_base_and_bit_offset always?
Otherwise, I can see this == COMPONENT_REF test growing over time.

I'll also note that vect_get_base_and_bit_offset should probably
be rewritten using get_inner_reference.  There are more cases to
handle than what you're currently doing.  Mostly they show up with
Ada, so you won't have seen them yet.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]