This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [arm] Fix thumb -fPIC


On Tue, 2004-10-12 at 19:51, Paul Brook wrote:
> > >  (thumb_find_work_register): Search full register range.
> >
> > I'm not 100% sure about the second issue.  LAST_LO_REGNUM is sometimes
> > used as a frame pointer register when we can't manage without one, have
> > you checked that it's safe to use it as a scratch in these conditions
> > (it may be, but I'm not sure).
> 
> I checked the function prologue usage, but missed the the use from 
> builtin_setjmp_reciever. Patch below fixes this case, which seemed to be 
> working by chance.
> 
> Tested with cross to arm-none-elf.
> Ok?
> 
> Paul
> 
> 2004-10-12  Paul Brook  <paul@codesourcery.com>
> 
>  * config/arm/arm-protos.h (arm_load_pic_register): Update prototype.
>  * config/arm/arm.c (thumb_find_work_register): Update comments.
>  (arm_load_pic_register): Add argument for scratch register.
>  (arm_expand_prologue, thumb_expand_prologue): Pass extra argument.
>  * config/arm/arm.md (builtin_setjmp_receiver): Ditto.

OK.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]