This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR 17896: clearer warning for &/&& glitches


"Thomas R. Truscott" <trt@cs.duke.edu> writes:

> --- 2300,2314 ----
>   	  /* Check cases like x&y==z */
>   	  if (TREE_CODE_CLASS (code1) == tcc_comparison
>   	      || TREE_CODE_CLASS (code2) == tcc_comparison)
> ! 	    {
> ! 	      if (COMPARISON_CLASS_P (arg1.value)
> ! 		  && !TREE_SIDE_EFFECTS (arg1.value)
> ! 		  && COMPARISON_CLASS_P (arg2.value)
> ! 		  && !TREE_SIDE_EFFECTS (arg2.value))
> ! 		warning ("suggest && instead of when joining booleans");
                                              ^^^
Typo.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]