This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Variable expansion patch review


Richard Kenner wrote:

   + /* An hash function for information about insns which contains
   +    accumulators to expand.  */

In addition to the two problems you mentioned, I still find this
sentence hard to understand. What is it that contains accumulators?
I suspect "which" should be "that", but even then it's not clear to me
(at least not from that sentence alone and it ought to be).


OK.

Revital, let's try this:

/* Return a hash for VES, which is really a "var_to_expand *". */

and, for the equality function:

/* Return true if IVTS1 and IVTS2 (which are really both of type "var_to_expand *") refer to the same instruction. */

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]