This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Variable expansion patch review


+ /* An hash function for information about insns which contains
+    accumulators to expand.  */

s|An|A

(This aspect of English grammar is tricky: it's correct to use "an" with some words that start with "h" and "a" with others.)

s|contains|contain

("insns" is plural; "contains" is singular; they should agree.)

+ /* An equality functions for information about insns which contains
+    accumulators to expand.  */

s|functions|function

("An" is singular while "functions" is plural; they should agree.)

s|contains|contain as above.

+ if (flag_variable_expansion_in_unroller
+ && can_apply)
+ {
+ opt_info->insns_with_var_to_expand = htab_create (5 * loop->num_nodes,
+ ve_info_hash, ve_info_eq, free);
+ }


Since there is only one dependent statement, the GNU coding standards say that you should not use curly braces here.

 #ifdef ENABLE_CHECKING
!                   if (!rtx_equal_p (PATTERN (insn), PATTERN (orig_insn)))
!                     abort ();

Use gcc_assert. (There are a couple of occurrences of this issue.)

+           "Limit the number of expansions an accumulator can have when \
+            expanding it in loop copies",

Let's say:

"If -fvariable-expansion-in-unroller is used, the maximum number of times that an individual variable will be expanded during loop unrolling."

Please make these changes and commit.

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]