This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix c/16999, #ident is outputted wrong frompreprocessor
Andrew Pinski <pinskia@physics.uc.edu> writes:
> On Oct 8, 2004, at 1:32 PM, Zack Weinberg wrote:
>
>> Andrew Pinski <pinskia@physics.uc.edu> writes:
>>
>>> This patch fixes the problem as the string is already quoted when
>>> we go
>>> out to print the string.
>>>
>>> OK for 3.4 and the mainline? Bootstrapped and tested on
>>> powerpc-darwin.
>>
>> OK. Please also add something to the test suite (suggest using dg-do
>> "preprocess" and dg-final to scan for an appropriate directive in the
>> preprocessed output).
>
> This is what I added to the testsuite:
Looks good. Thanks.
> The line is not wrapped, it is my mailer being messed up (and I don't
> know how to fix it).
Attach patches instead of putting them inline? I think even the
people who don't like attachments very much prefer them to mangled
patches.
zw