This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Java: Use New Quoting Style in Diagnostics (2/n)
- From: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
- To: Per Bothner <per at bothner dot com>
- Cc: Ranjit Mathew <rmathew at gmail dot com>, GCJ Patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 7 Oct 2004 21:25:39 +0000 (UTC)
- Subject: Re: [Patch] Java: Use New Quoting Style in Diagnostics (2/n)
- References: <39399b9d04100712231f0666f9@mail.gmail.com> <4165AF2C.2000801@bothner.com>
On Thu, 7 Oct 2004, Per Bothner wrote:
> Ranjit Mathew wrote:
>
> > - sprintf (buffer, " with `%s'",
> > + sprintf (buffer, " with '%s'",
>
> > - sprintf (buffer, "\n which inherits from `%s' (%s:%d)",
> > + sprintf (buffer, "\n which inherits from '%s' (%s:%d)",
>
> > - fprintf (stderr, "In class `%s':\n",
> > + fprintf (stderr, "In class '%s':\n",
>
> Should these use %qs? Or do those cases not go through the
> necessary machinary? The lhd_print_error_function in
> langhooks.c uses $qs.
The lhd_print_error_function uses pp_printf - these use plain
sprintf/fprintf.
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
joseph@codesourcery.com (CodeSourcery mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)