This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973,removing labels with their address taken
On Tue, 2004-10-05 at 20:13, Andrew Pinski wrote:
> On Oct 5, 2004, at 6:35 PM, Jeffrey A Law wrote:
> > If we're going to allow this, then I would strongly recommend
> > against this approach to the problem. Instead just move
> > these labels to the start of their nearest following block that
> > is reachable.
> Well then you have to fix cfgcleanup which is done using non-tree
> or non-RTL code. This is much harder than it should be for the
> problem at hand which is why I picked the method I did.
Harder or not, it's a much better solution.
>
> > Inserting arbitrary edges into the CFG is generally bad.
>
> Usually it is but this case does not show up too much so really
> it should not matter that much as I said before.
We've already been down this road before. Adding bogus edges to the
CFG is bad bad bad.
Jeff