This is the mail archive of the
mailing list for the GCC project.
Re: [3.4 PATCH] Fix IRIX bootstrap failure in libstdc++
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Tue, 05 Oct 2004 15:57:16 -0700
- Subject: Re: [3.4 PATCH] Fix IRIX bootstrap failure in libstdc++
- Organization: CodeSourcery, LLC
- References: <Pine.LNX.firstname.lastname@example.org>
Roger Sayle wrote:
Yes, this is OK for 3.4. For the mainline, one of the V3 people should
mips-sgi-irix6.5 currently fails to bootstrap on both mainline and
the gcc 3.4 branch. The patch below restores bootstrap on the
gcc-3_4-branch, and should resolve one of the multiple breakages
on mainline (for example, Richard Sandiford's fixproto/fix-headers
patch http://gcc.gnu.org/ml/gcc-patches/2004-09/msg03008.html is
The failures addressed below are the unresolved references to
strtof and strtold whilst linking libstdc++. The problem is that
config/locale/generic/c_locale.cc currently guards its uses of
strtof and strtold with #ifdef _GLIBCXX_USE_C99. Unfortunately on
MIPS/IRIX, _GLIBCXX_USE_C99 is defined, even though the corresponding
_GLIBCXX_HAVE_STRTOF and _GLIBC_HAVE_STRTOLD aren't. The proposed
fix is to use the finer granularity configure HAVE_foo tests instead
of the more generic _GLIBCXX_USE_C99.
The following patch has been tested on i686-pc-linux-gnu with a full
"make bootstrap", all default languages, and regression tested with a
top-level "make -k check" with no new failures. As mentioned above,
this patch also restores bootstrap of the gcc-3_4-branch for all
default languages on mips-sgi-irix6.5.
Ok for mainline and the gcc-3_4-branch? Given that mips-sgi-irix6.5
is a primary evaluation platform in gcc-3.4/criteria.html, I think
this needs to be fixed for gcc 3.4.3.