This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix intrinsic_pack.f90, tree-nested not marking somedecls as addressable
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 05 Oct 2004 22:57:06 +0200
- Subject: Re: [PATCH] Fix intrinsic_pack.f90, tree-nested not marking somedecls as addressable
- References: <BD7BFC2A-16FB-11D9-B1A5-000A95D692F4@physics.uc.edu>
Andrew Pinski wrote:
> The problem here is that we have "&a[4];" which we change to
> &FRAME.117.a[4]; in tree-nested but we don't mark the frame as
> addressable so we get an ICE. This fixes the problem by instead
> of checking if the immediate part of the ADDR_EXPR we should check
> that we changed any part of the address expression.
>
> OK? Bootstrapped and tested on powerpc-darwin.
>
> The testcase is already in the testsuite and fails currently.
Thanks for fixing this, which is now PR17849. One remark: intrinsic_pack.f90
as is is not meant to stay, as a series of tests in it are currently commented
out and are waiting for a fix for PR17756 to be committed, and if those tests
are not commented out the bug you're fixing doesn't show itself. Or at least
it didn't when I tried earlier today. IOW a separate testcase would be a good
thing.
- Tobi