This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix const-str-[34].m on darwin


Hey Andrew,

One nit:

-
+      else
+        {
+	  var = build_decl (CONST_DECL, NULL, TREE_TYPE (constructor));
+	  DECL_INITIAL (var) = constructor;
+	  if (global_bindings_p ())
+	    TREE_STATIC (var) = 1;
+	  pushdecl (var);
+	  constructor = var;
+	}

I think you want to use 'pushdecl_top_level' so that each CONST_DECL can get
referenced from anywhere in the file. You'll probably need to perform a
song and dance similar to build_objc_string_decl()'s. :-)


--Zem

--------------------------------------------------------------
Ziemowit Laski                 1 Infinite Loop, MS 301-2K
Mac OS X Compiler Group        Cupertino, CA USA  95014-2083
Apple Computer, Inc.           +1.408.974.6229  Fax .5477


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]