This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFC] Enable java on sh64-linux (Take 2)


Kaz Kojima writes:
 > Tom Tromey <tromey@redhat.com> wrote:
 > > Kaz> I'd like to see the divide overflow handler.
 > > 
 > > The usual solution to this problem is to turn on
 > > -fuse-divide-subroutine in configure.host for your platform.  See,
 > > e.g., libjava/prims.cc:_Jv_divI() for what is supposed to happen.
 > > Divide_1 just tests all these cases.
 > 
 > I've noticed that -fuse-divide-subroutine is used already for this
 > target and found that a libffi problem of this target causes
 > the Divide_1 failure with gij.  SH-5 has 64-bit integer registers
 > and I've forgot to extend 32-bit signed integers to 64-bit signed
 > integers when storing them to 64-bit width memory in ffi_prep_args.

...

 > BTW, it's surprising that no testcase could detect the above problem,
 > isn't it?  How about the testcase below?  It caught this mistake.

That's good.  The libffi testsuite is far from complete.

I'm betting on libffi mistakes for the rest of the gij failures, too.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]