This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PRs c/17178 and c/17820
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 03 Oct 2004 16:30:38 -0700
- Subject: Re: [PATCH] Fix PRs c/17178 and c/17820
- References: <953F02F2-1592-11D9-81C0-000A95D692F4@physics.uc.edu>
Andrew Pinski <pinskia@physics.uc.edu> writes:
> When Zack committed one of his c-decl rewrites, he had forgot that
> the middle-end (toplev.c) already warned about static variables.
> The code in pop_scope in c-decl.c should take that into account and
> only warn on variables which are not in either the global or file
> scopes.
>
> OK? Bootstrapped and tested on powerpc-apple-darwin with no
> regressions.
This is OK. I would kind-of rather that toplev.c didn't do this (on
the "all diagnostics are the responsibility of the front end"
principle), but that's presumably too big a change for right now.
zw