This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed Patch [H8/300] : Patch for -mno-exr option in caseof function with "monitor" attribute
- From: Kazu Hirata <kazu at cs dot umass dot edu>
- To: SherryS at KPITCummins dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 27 Sep 2004 10:26:06 -0400 (EDT)
- Subject: Re: Unreviewed Patch [H8/300] : Patch for -mno-exr option in caseof function with "monitor" attribute
- References: <4A1BE23A7B777442B60F4B4916AE0F130239AC0E@sohm.kpit.com>
Hi Sherry,
Some minor nits.
> + * Behaviour of RTE instruction depends on H8S model and operation mode.
s/Behaviour/Behavior/
> +#define TARGET_EXR (target_flags & MASK_EXR)
> +#define TARGET_NEXR ( target_flags & MASK_NEXR)
Can you just have one of these instead of two?
> + if (! TARGET_H8300S && TARGET_EXR)
> + {
> + error ("-mexr is used without -ms");
> + target_flags |= MASK_H8300S;
> + }
Please fix indentation. We indent by two characters.
> +int
> +h8300_current_function_monitor_function_p ()
A function needs a short comment before it.
> - if (h8300_current_function_interrupt_function_p ())
> + if (h8300_current_function_interrupt_function_p ()
> + || h8300_current_function_monitor_function_p () )
Please fix indentation.
Kazu Hirata