This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed patch - Fix PR tree-optimization/17512.
- From: Jeffrey A Law <law at redhat dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: Roger Sayle <roger at eyesopen dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at redhat dot com>
- Date: Thu, 23 Sep 2004 23:08:01 -0600
- Subject: Re: Unreviewed patch - Fix PR tree-optimization/17512.
- Organization: Red Hat, Inc
- References: <Pine.LNX.4.44.0409221124330.23361-101000@www.eyesopen.com> <6C0A3C73-0CF3-11D9-921D-000A95D692F4@physics.uc.edu>
- Reply-to: law at redhat dot com
On Wed, 2004-09-22 at 17:59, Andrew Pinski wrote:
> On Sep 22, 2004, at 1:43 PM, Roger Sayle wrote:
>
> >
> > On Wed, 22 Sep 2004, Andrew Pinski wrote:
> >> Could you send me the preprocessed source for this bug? Since I was
> >> the one who added the case where the types differ, I would like to fix
> >> this bug.
> >
> > It'll take me a few minutes to add the abort to build2 in tree.c and
> > start a bootstrap to identify which file in libstdc++-v3 triggered the
> > failure. Reproduced it! I can now get it to trigger with c-decl.c in
> > stage2. The preprocessed source file is attached.
>
> It was a thinko on my part when I wrote this code.
>
> OK? Bootstrapped and tested on powerpc-apple-darwin.
>
> Thanks,
> Andrew Pinski
>
>
> ChangeLog:
> * tree-ssa-phiopt.c (conditional_replacement): Use the correct
> type with the copy of the conditional.
This is fine. Presumably you have a testcase for the testsuite
as well?
jeff