This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC: Faster cp_lexer_peek_token [revised]
- From: Gabriel Dos Reis <gdr at cs dot tamu dot edu>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: 23 Sep 2004 07:52:16 -0500
- Subject: Re: RFC: Faster cp_lexer_peek_token [revised]
- Organization: Texas A&M University, Department of Computer Science
- References: <874qlpxyi0.fsf@codesourcery.com>
Zack Weinberg <zack@codesourcery.com> writes:
| This patch is a revised version of the one I posted this morning,
| <http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02284.html>. See that
| message for discussion of the basic change and why it is a good idea.
|
| The revisions correct all of the regressions in the test suite which I
| observed via testing on powerpc-darwin. I'm going to do overnight
| testing on amd64-linux too. Most of the regressions were due to error
| messages moving, and in many cases I decided that the new locations
| were better. In particular, given a typical function definition
|
| return_type function(argument list)
| {
| body
| }
|
| if g++ found something objectionable about the head, the diagnostic
| used to issue on the line of the opening brace; now it appears on the
| line of the head itself. I think this is better.
As the diagnostic maintainer, I applaude for this move. I leave the
other C++ bits for Jason and Mark to comment on.
-- Gaby