This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: #pragma pack fixes (PR c/7054)


Gerald Pfeifer wrote:

>>> Jan, can you prepare a patch for
>>> http://gcc.gnu.org/gcc-3.5/changes.html describing this change (and
>>> also the new NetWare target)?
>> Here it is (though unsure whether wording and placement are as
>> expected):
>
> Looks fine.  I went ahead and installed your patch with most minor
> tweaks.

I would object about where it says: "#pragma pack() semantics have been brought
closer to those used by other compilers". I do not think this explains anything
to the users. At the very least, I would add something like "Please consult the
documentation to get more details about exactly what changes were done"
(assuming the documentation was updated to explain these differences that were
now fixed), but I would prefer a little explanation directly in changes.html
too.

Giovanni Bajo



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]