This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: don't name temporary variables



On 10/09/2004, at 5:51 PM, Daniel Berlin wrote:




On Fri, 10 Sep 2004, Geoffrey Keating wrote:


On 10/09/2004, at 5:27 PM, Daniel Berlin wrote:


This should probably be predicated on ENABLE_CHECKING being off.
Otherwise, you only the UID to go by, and that looks incredibly ugly.

Would it help if the UID was printed as 'D.xxxx' instead of '<Dxxxxx>'?
Yes.

Then, if there are no objections, I'll commit this once 'make check' finishes.


2004-09-10 Geoffrey Keating <geoffk@apple.com>

        * tree-pretty-print.c (dump_decl_name): Print unnamed decls as
        D.xxx rather than <Dxxx>.

*** tree-pretty-print.c.~2.35.~ Thu Sep  9 13:14:47 2004
--- tree-pretty-print.c Fri Sep 10 17:55:54 2004
***************
*** 162,173 ****
      {
        if (TREE_CODE (node) == LABEL_DECL
          && LABEL_DECL_UID (node) != -1)
!       pp_printf (buffer, "<L" HOST_WIDE_INT_PRINT_DEC ">",
                   LABEL_DECL_UID (node));
        else
        {
          char c = TREE_CODE (node) == CONST_DECL ? 'C' : 'D';
!         pp_printf (buffer, "<%c%u>", c, DECL_UID (node));
        }
      }
  }
--- 162,173 ----
      {
        if (TREE_CODE (node) == LABEL_DECL
          && LABEL_DECL_UID (node) != -1)
!       pp_printf (buffer, "L." HOST_WIDE_INT_PRINT_DEC,
                   LABEL_DECL_UID (node));
        else
        {
          char c = TREE_CODE (node) == CONST_DECL ? 'C' : 'D';
!         pp_printf (buffer, "%c.%u", c, DECL_UID (node));
        }
      }
  }

Attachment: smime.p7s
Description: S/MIME cryptographic signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]